[PATCH] rs6000/test: Adjust some cases due to O2 vect [PR102658]
Jeff Law
jeffreyalaw@gmail.com
Tue Oct 12 17:45:14 GMT 2021
On 10/12/2021 11:15 AM, Martin Sebor via Gcc-patches wrote:
> On 10/12/21 10:18 AM, Segher Boessenkool wrote:
>> Hi!
>>
>> On Tue, Oct 12, 2021 at 09:49:19AM -0600, Martin Sebor wrote:
>>> Coming back to the xfail conditionals, do you think you'll
>>> be able to put together some target-supports magic so they
>>> don't have to enumerate all the affected targets?
>>
>> There should only be an xfail if we do not expect to be able to fix the
>> bug causing this any time soon. There shouldn't be one here, not yet
>> anyway.
>>
>> Other than that: yes, and one you have such a selector, just dg-require
>> it (or its inverse) for this test, don't xfail the test (if this is
>> expected and correct behaviour).
>
> My sense is that fixing all the fallout from the vectorization
> change is going to be delicate and time-consuming work. With
> the end of stage 1 just about a month away I'm not too optimistic
> how much of it I'll be able to get it done before then. Depending
> on how intrusive the fixes turn out to be it may or may not be
> suitable in stage 3.
>
> Based on pr102706 that Jeff reported for the regressions in his
> automated tester, it also sounds like the test failures are spread
> out across a multitude of targets. In addition, it doesn't look
> like the targets are all the same in all the tests. Enumerating
> the targets that correspond to each test failure would be like
> playing the proverbial Whac-A-Mole.
There'll be some degree of whac-a-mole. But it likely isn't every
target. I'm still evaluating that when I have a few minutes to look at
a given target.
jeff
More information about the Gcc-patches
mailing list