[PATCH] [PR/target 100316] Allow constant address for __builtin___clear_cache.

Andrew Pinski pinskia@gmail.com
Thu Oct 7 21:20:41 GMT 2021


On Thu, Oct 7, 2021 at 9:47 AM Kito Cheng <kito.cheng@gmail.com> wrote:
>
> Hi Andrew:
>
> > Seems like this error should be an gcc_assert at this point.  The
> > error message should have come from expand_builtin___clear_cache
> > already.
>
> Actually it will emit errors here, so put gcc_assert will cause ICE :p

The error message would have been emitted from
expand_builtin___clear_cache and maybe_emit_call_builtin___clear_cache
 would not have been called from user code.
All other uses of maybe_emit_call_builtin___clear_cache are internal
to gcc and should have the correct mode so asserting is the right
thing to do.

Thanks,
Andrew Pinski

>
> > And the check for VOIDmode should really be a check for CONST_INT.
>
> Yeah, that makes sense, thanks!


More information about the Gcc-patches mailing list