[PATCH] rs6000: Remove builtin mask check from builtin_decl [PR102347]
Segher Boessenkool
segher@kernel.crashing.org
Tue Nov 30 00:07:11 GMT 2021
Hi!
On Mon, Oct 11, 2021 at 02:30:42PM +0800, Kewen.Lin wrote:
> > If we do need a band-aid for 10 and 11 (and we do as far as I can see),
> > I'd like to see one for just MMA there, and let all other badness fade
> > into history. Unless you can convince me (in the patch / commit
> > message) that this is safe :-)
>
> Just to fix for MMA seems incomplete to me since we can simply
> construct one non-MMA but failed case. I questioned in the other
> thread, is there any possibility for one invalid target specific
> bif to escape from the function rs6000_expand_builtin? (note that
> folding won't handle invalid bifs, so invalid bifs won't get folded
> early.) If no, I think it would be safe.
It is much safer and simpler to not backport anything we do not need to.
You need to come up with a reason why it would be a good idea to do
backport something, especially if it isn't obviously super safe.
Segher
More information about the Gcc-patches
mailing list