[PATCH 1/2] Split return functionality of get_non_stale_global_range.

Andrew MacLeod amacleod@redhat.com
Wed Nov 24 14:06:57 GMT 2021


On 11/24/21 04:16, Richard Biener wrote:
> On Tue, Nov 23, 2021 at 6:03 PM Andrew MacLeod via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
>> This is the first of 2 patches which will reduce the depth of the call
>> chain in ranger.
>>
>> This patch simply splits the functionality of the routine
>> get_non_stale_global_range() from a single boolean return to a boolean
>> return and a bool reference.
>>
>> This routine queries the global cache for a value.  If  there is no
>> value, it queries the legacy global range and sets it to that value.  If
>> there was a value, it checks the temporal cache to see if its current,
>> and if it is, returns TRUe plus the range.
>>
>> If the value is not currrent, or it was set to the legacy global value,
>> then the timestamp is marked as "always current" as it indicates a
>> calculation is ongoing, and we dont want to trigger any additional
>> temporal faults until the calculation is done. And finallt FALSE is
>> returned for all these cases.
>>
>> The second patch in the series wants to disambiguate at the call site
>> whether this was a failure due to not being in the global cache, or
>> whether it was due to the timestamp being out of date and take different
>> actions for each case.   Details in the following note.
>>
>> This has been Bootstrapped on x86_64-pc-linux-gnu with no regressions.  OK?
> OK.
>
> Richard.
>
committed.




More information about the Gcc-patches mailing list