[PATCH] PR tree-optimization/103254 - Limit depth for all GORI expressions.

Andrew MacLeod amacleod@redhat.com
Fri Nov 19 14:38:34 GMT 2021


On 11/19/21 05:15, Aldy Hernandez wrote:
>
>
> On 11/18/21 8:28 PM, Andrew MacLeod wrote:
>
>> @@ -376,6 +366,14 @@ range_def_chain::get_def_chain (tree name)
>>        return NULL;
>>      }
>>
>> +  // Terminate the def chains if we see too many cascading stmts.
>> +  if (m_logical_depth == param_ranger_logical_depth)
>> +    return NULL;
>> +
>> +  // Increase the depth if we have a pair of ssa-names.
>> +  if (ssa1 && ssa2)
>> +    m_logical_depth++;
>> +
>
> Not sure it matters, since this is an internal knob, but if the 
> --param now applies to all statements, perhaps we should remove the 
> "logical" reference from the knob.
>
> Aldy
>
I considered that, but recall the last time I changed a name in my 
--param it affected some LTO reading thing invalidating existing objects 
due to a parameter mismatch I think... So I didn't see the need :-)   So 
instead I now interpret it to mean "Logical analysis depth"  or 
something :-)     If no one cares about that, we could drop the logical 
part of it.

Andrew





More information about the Gcc-patches mailing list