[PATCH] configure: define TARGET_LIBC_GNUSTACK on musl

Ilya Lipnitskiy ilya.lipnitskiy@gmail.com
Tue Nov 16 05:10:46 GMT 2021


On Mon, Nov 15, 2021 at 2:50 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
>
> On 11/15/2021 1:25 AM, Ilya Lipnitskiy via Gcc-patches wrote:
> > musl only uses PT_GNU_STACK to set default thread stack size and has no
> > executable stack support[0], so there is no reason not to emit the
> > .note.GNU-stack section on musl builds.
> >
> > [0]: https://lore.kernel.org/all/20190423192534.GN23599@brightrain.aerifal.cx/T/#u
> >
> > gcc/ChangeLog:
> >
> >       * configure: Regenerate.
> >       * configure.ac: define TARGET_LIBC_GNUSTACK on musl
> If musl has no executable stack support, then wouldn't we want this
> change to apply to all musl platforms, not just mips?
The original change was MIPS-specific[0] and TARGET_LIBC_GNUSTACK is
only used by mips code today. We could change both cases to be more
generic or keep it MIPS-specific. Dragan, what do you think?

I also need to re-spin my change as my case is a more specific match
than the first and never executes with my patch.

[0]: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=54b3d52c3cca836c7c4c08cc9c02eda6c096372a
>
> jeff
>
Ilya


More information about the Gcc-patches mailing list