[PATCH][committed]middle-end: Fix signbit tests when ran on ISA with support for masks.

Tamar Christina Tamar.Christina@arm.com
Wed Nov 10 18:53:34 GMT 2021


FAIL: gcc.dg/signbit-2.c scan-tree-dump-times optimized "[file://\\s+]\\s+>\\s+{ 0,
0, 0, 0 }" 1

That's the old test which this patch has changed. Does it still fail with the new patch?
________________________________
From: Sandra Loosemore <sandra@codesourcery.com>
Sent: Wednesday, November 10, 2021 6:37 PM
To: Tamar Christina <Tamar.Christina@arm.com>; gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>; rguenther@suse.de <rguenther@suse.de>
Subject: Re: [PATCH][committed]middle-end: Fix signbit tests when ran on ISA with support for masks.

On 11/10/21 4:54 AM, Tamar Christina via Gcc-patches wrote:
> Hi All,
>
> These test don't work on vector ISAs where the truth
> type don't match the vector mode of the operation.
>
> However I still want the tests to run on these
> architectures but just turn off the ISA modes that
> enable masks.
>
> This thus turns off SVE is it's on and turns off
> AVX512 if it's on.
>
> Regtested on aarch64-none-linux-gnu with SVE on,
> and x86_64-pc-linux-gnu with AVX512 on and no
> issues.
>
> Committed under the obvious rule.
>
> Thanks,
> Tamar
>
> gcc/testsuite/ChangeLog:
>
>        * gcc.dg/signbit-2.c: Turn of masks.
>        * gcc.dg/signbit-5.c: Likewise.

I'm seeing this failure on nios2-elf:

FAIL: gcc.dg/signbit-2.c scan-tree-dump-times optimized "\\s+<file://\\s+>>\\s+{ 0,
0, 0, 0 }" 1

I don't understand what it is expecting to happen here.  Should it be
skipped on this target, or restricted to ARM and x86?  Adding some
comments to the testcase to explain the significance of that pattern
might be useful too.

-Sandra




More information about the Gcc-patches mailing list