[PATCH v7] attribs: Implement -Wno-attributes=vendor::attr [PR101940]

Bernhard Reutner-Fischer rep.dot.nop@gmail.com
Tue Nov 9 19:47:02 GMT 2021


On Tue, 9 Nov 2021 14:17:14 -0500
Marek Polacek <polacek@redhat.com> wrote:

> +      if (!valid_p (vendor_start, vendor_len)
> +	  || !valid_p (attr_start, attr_len))
> +	{
> +	  error ("wrong argument to ignored attributes");
> +	  continue;
> +	}
> +      canonicalize_attr_name (vendor_start, vendor_len);
> +      /* We perform all this hijinks so that we don't have to copy OPT.  */
> +      tree vendor_id = get_identifier_with_length (vendor_start, vendor_len);

[[____::attry]] void f17y(); /* { dg-warning "ignored" } */

so i'd maybe put the
|| !canonicalize_attr_name (vendor_start, vendor_len)
in the condition above?

thanks,


More information about the Gcc-patches mailing list