[PATCH v1 1/7] LoongArch Port: gcc
Mon Nov 8 23:14:28 GMT 2021
> +#define GLIBC_DYNAMIC_LINKER_LP64 "/lib64/ld.so.1"
See my comments on the glibc patch series
Specifically, the point that all new glibc ports should have unique
per-ABI dynamic linker names for each ABI supported by the port,
preferably referencing the architecture name somewhere in the dynamic
linker name. /lib64/ld.so.1 is a name that's already in use, so should
not be used by any ABI of this new port.
> + error ("%<-march=%s%> does not work on a cross compiler.",
Error messages should not end with '.'.
> + error ("%<-mtune=%s%> does not work on a cross compiler.",
I didn't see any additions to contrib/config-list.mk anywhere in the patch
series. (See "Back End" in sourcebuild.texi for a list of places you may
need to update as part of a GCC port, including config-list.mk.)
Please make sure the back end builds cleanly with current GCC mainline.
This can be tested either with a native bootstrap, or by building a cross
compiler, using a native compiler of the same GCC mainline version for the
build and configuring using --enable-werror-always (that configure option
has the effect of enabling -Werror in the same way that later bootstrap
stages in a native bootstrap do).
Joseph S. Myers
More information about the Gcc-patches