[PATCH 18/18] rs6000: Add escape-newline support for builtins files

Bill Schmidt wschmidt@linux.ibm.com
Mon Nov 8 19:40:44 GMT 2021


On 11/5/21 6:50 PM, Segher Boessenkool wrote:
> Hi!
>
> On Wed, Sep 01, 2021 at 11:13:54AM -0500, Bill Schmidt wrote:
>> +/* Escape-newline support.  For readability, we prefer to allow developers
>> +   to use escape-newline to continue long lines to the next one.  We
>> +   maintain a buffer of "original" lines here, which are concatenated into
>> +   linebuf, above, and which can be used to convert the virtual line
>> +   position "line / pos" into actual line and position information.  */
>> +#define MAXLINES 4
> Make this bigger already?  Or, want to bet if we will need to increase
> it for GCC 12 already?  Because for GCC 13 we almost certainly will :-)

We *could*, but honestly I don't think we'll need it anytime soon.  The only
reason we need 4 is for a single built-in that takes sixteen parameters:

+  const vsc __builtin_vec_init_v16qi (signed char, signed char, signed char, \
+            signed char, signed char, signed char, signed char, signed char, \
+            signed char, signed char, signed char, signed char, signed char, \
+            signed char, signed char, signed char);

It's hard to think of a rational built-in that will need more space than this.
We can always make it bigger later if needed.

I'll make the rest of the cleanups you suggested.  Thanks again for the review!

Bill




More information about the Gcc-patches mailing list