[PATCH] ipa: Unshare expresseions before putting them into debug statements (PR 103099, PR 103107)

Jan Hubicka hubicka@kam.mff.cuni.cz
Mon Nov 8 16:29:31 GMT 2021


> Hi,
> 
> my recent patch to improve debug experience when there are removed
> parameters (by ipa-sra or ipa-split) was not careful to unshare the
> expressions that were then put into debug statements, which manifests
> itself as PR 103099.  This patch adds unsharing them using
> unshare_expr_without_location which is a bit more careful with stripping
> locations than what we were doing manually and so also fixes PR 103107.
> 
> Bootstrapped an tested on x86_64-linux.  OK for master?
> 
> Thanks,
> 
> Martin
> 
> gcc/ChangeLog:
> 
> 2021-11-08  Martin Jambor  <mjambor@suse.cz>
> 
> 	PR ipa/103099
> 	PR ipa/103107
> 	* tree-inline.c (remap_gimple_stmt): Unshare the expression without
> 	location before invoking remap_with_debug_expressions on it.
> 	* ipa-param-manipulation.c
> 	(ipa_param_body_adjustments::prepare_debug_expressions): Likewise.
> 
> gcc/testsuite/ChangeLog:
> 
> 2021-11-08  Martin Jambor  <mjambor@suse.cz>
> 
> 	PR ipa/103099
> 	PR ipa/103107
> 	* g++.dg/ipa/pr103099.C: New test.
> 	* gcc.dg/ipa/pr103107.c: Likewise.
OK,
thanks!
Honza


More information about the Gcc-patches mailing list