[PATCH] rs6000: Remove unnecessary option manipulation.

Martin Liška mliska@suse.cz
Thu Nov 4 10:08:32 GMT 2021


@Segher: PING

On 10/19/21 16:43, Martin Liška wrote:
> On 10/19/21 16:23, Segher Boessenkool wrote:
>> On Fri, Oct 15, 2021 at 05:24:32PM +0200, Martin Liška wrote:
>>> On 10/14/21 17:10, Bill Schmidt via Gcc-patches wrote:
>>>> Looks like you got your parentheses wrong here.
>>>
>>> Whoops, thanks for the heads up.
>>>
>>> I'm testing this fixed version.
>>
>> Please start a new thread for every new patch (series).  I missed this
>> one like this, instead I reviewed the older one.
> 
> Is it really best practice. My impression is that patch review (iterating over
> a patch) happens in the same thread (in most cases). It's caused by discussion
> in between sender reviewers.
> 
>>
>> [-- Attachment #2: 0001-rs6000-Remove-unnecessary-option-manipulation.patch --]
>> [-- Type: text/x-patch, Encoding: base64, Size: 2.6K --]
> 
> Meh :) If I need a reply to somebody's questions, I always attach patch as an attachment.
> And I can't likely influence how Thunderbird is going to mark it.
> 
>>
>> Don't encode as non-text.  Don't use x-anything if you can help it, it
>> is meaningless in email.
>>
>> Use git send-email, it makes everything work :-)
> 
> I know.
> 
> Anyway, sending updated version of the patch.
> 
> Cheers,
> Martin
> 
>>
>>
>> Segher
>>




More information about the Gcc-patches mailing list