[PATCH][GCC 11] ranger: Fix `-Werror' build error with `ranger_cache::push_poor_value'
Maciej W. Rozycki
macro@embecosm.com
Wed Nov 3 11:35:04 GMT 2021
Remove a commit 86534c07a390 ("Disable poor value processing in ranger
cache.") regression that caused GCC not to build anymore if `-Werror'
has been enabled:
.../gcc/gimple-range-cache.cc: In member function 'bool ranger_cache::push_poor_value(basic_block, tree)':
.../gcc/gimple-range-cache.cc:850:44: error: unused parameter 'bb' [-Werror=unused-parameter]
850 | ranger_cache::push_poor_value (basic_block bb, tree name)
| ~~~~~~~~~~~~^~
.../gcc/gimple-range-cache.cc:850:53: error: unused parameter 'name' [-Werror=unused-parameter]
850 | ranger_cache::push_poor_value (basic_block bb, tree name)
| ~~~~~^~~~
To keep the change to the minimum mark the parameters reported unused.
gcc/
* gimple-range-cache.cc (ranger_cache::push_poor_value): Mark
parameters unused.
---
Hi,
Probably obvious, OK to apply?
[It's been a while since the offending commit; I guess nobody configures
release branches with `--enable-werror-always'?]
Maciej
---
gcc/gimple-range-cache.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
gcc-ranger-cache-push-poor-value-unused.diff
Index: gcc/gcc/gimple-range-cache.cc
===================================================================
--- gcc.orig/gcc/gimple-range-cache.cc
+++ gcc/gcc/gimple-range-cache.cc
@@ -847,7 +847,8 @@ ranger_cache::register_dependency (tree
// the request is actually made (ie, isn't a duplicate).
bool
-ranger_cache::push_poor_value (basic_block bb, tree name)
+ranger_cache::push_poor_value (basic_block bb ATTRIBUTE_UNUSED,
+ tree name ATTRIBUTE_UNUSED)
{
// Disable poor value processing for GCC 11. It has been disabled in GCC 12
// as adding too much churn/compile time for too little benefit.
More information about the Gcc-patches
mailing list