[Ping^2, Patch, Fortran] PR98301 Re: RANDOM_INIT() and coarray Fortran

[Martin Liška]

On 5/23/21 1:59 PM, Andre Vehreschild wrote:
> Hi Martin,
> 
> thanks for pointing that out. I haven't committed for quite some time now and
> could not find on the webpage how this works nowadays. I was thinking that the
> special gcc-git-command should have added the Changelog entries automagically
> and immediately. That they are added by a daily bump is new to me. Thanks for
> giving me more insight.

Sure, I'm fully aware that occasional committers are not aware of that.

> 
> So do I need to revert the commit c4771b3438a8cd9afcef1762957b763f8df3fa6e to
> fix the Changelogs or how do we proceed from here?

I've just done that.

> Is there a webpage which describes the current state-of-art of committing to
> gcc for folks that do not follow every discussion on the mailing lists?

It's documented here:
https://gcc.gnu.org/codingconventions.html#ChangeLogs

But it's far from a good location. I'm going to improve it.

Cheers,
Martin

> 
> Thanks for your help,
> 	Andre
> On Sat, 22 May 2021 19:58:57 +0200
> Martin Liška <mliska@suse.cz> wrote:
> 
>> On 5/22/21 1:39 PM, Andre Vehreschild via Gcc-patches wrote:
>>> Hi Steve and Jerry,
>>>
>>> thanks for the ok'ing.
>>>
>>> Committed as https://gcc.gnu.org/g:26ca6dbda23bc6dfab96ce07afa70ebacedfaf9c
>>> and https://gcc.gnu.org/g:c4771b3438a8cd9afcef1762957b763f8df3fa6e (for the
>>> missing changelog entries).
>>
>> Hello.
>>
>> About the missing changelog entries. The will be added automatically by Daily
>> bump. You can check it with:
>> ./contrib/gcc-changelog/git_check_commit.py
>> 26ca6dbda23bc6dfab96ce07afa70ebacedfaf9c -p
>>
>> What's missing for you so that you pushed
>> c4771b3438a8cd9afcef1762957b763f8df3fa6e?
>>
>> Thanks,
>> Martin
>>
>>>
>>> - Andre
>>>
>>> On Fri, 21 May 2021 19:38:00 -0700
>>> Jerry D <jvdelisle2@gmail.com> wrote:
>>>    
>>>> yes, please commit
>>>>
>>>> On 5/21/21 8:08 AM, Steve Kargl via Fortran wrote:
>>>>> On Fri, May 21, 2021 at 10:09:02AM +0200, Andre Vehreschild wrote:
>>>>>> Ping, ping!
>>>>>>
>>>>>> Please find attached a rebased version of the patch for the RANDOM_INIT
>>>>>> issue with coarray Fortran. Nothing changed to the previous version, just
>>>>>> rebased to current master.
>>>>>>
>>>>>> Regtested fine on x86_64-linux/f33. Ok for trunk?
>>>>>>   
>>>>> I think you've down your due diligence with 2 pings.
>>>>> I would commit.
>>>>>   
>>>>   
>>>
>>>
>>> --
>>> Andre Vehreschild * Email: vehre ad gmx dot de
>>>    
>>
> 
>