[PATCH, V2] Add conversions between _Float128 and Decimal.

Michael Meissner meissner@linux.ibm.com
Mon Mar 29 17:47:13 GMT 2021


On Sat, Mar 27, 2021 at 04:07:18PM +0100, Florian Weimer wrote:
> This issue is still present.
> 
> What about the patch below?
> 
> Thanks,
> Florian
> 
> rs6000: Do not build _Float128/Decimal routines with --disable-decimal-float
> 
> Fixes commit 781183595acba67a37c66f59a0c1d9b5fee7e248 ("Add conversions
> between _Float128 and Decimal.).
> 
> libgcc/
> 	* config/rs6000/t-float128 (fp128_ppc_funcs): Add decimal floating
> 	point functions for $(decimal_float) only.
> 
> diff --git a/libgcc/config/rs6000/t-float128 b/libgcc/config/rs6000/t-float128
> index 6fb1a3d871b..b1f00accdf1 100644
> --- a/libgcc/config/rs6000/t-float128
> +++ b/libgcc/config/rs6000/t-float128
> @@ -37,8 +37,11 @@ ibm128_dec_funcs	= _tf_to_sd _tf_to_dd _tf_to_td \
>  # New functions for software emulation
>  fp128_ppc_funcs		= floattikf floatuntikf fixkfti fixunskfti \
>  			  extendkftf2-sw trunctfkf2-sw \
> -			  sfp-exceptions _mulkc3 _divkc3 _powikf2 \
> -			  $(fp128_dec_funcs) $(fp128_decstr_funcs)
> +			  sfp-exceptions _mulkc3 _divkc3 _powikf2
> +
> +ifeq ($(decimal_float),yes)
> +fp128_ppc_funcs	+= $(fp128_dec_funcs) $(fp128_decstr_funcs)
> +endif
>  
>  fp128_ppc_src		= $(addprefix $(srcdir)/config/rs6000/,$(addsuffix \
>  				.c,$(fp128_ppc_funcs)))
> 

That patch looks ok (assuming you've tested it).  There are still the wider
issues that Segher wanted addressed, but it should fix the problem with
disabling decimal float.

-- 
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meissner@linux.ibm.com, phone: +1 (978) 899-4797


More information about the Gcc-patches mailing list