[PATCH] x86: Skip ISA check for always_inline in system headers

Richard Biener richard.guenther@gmail.com
Fri Mar 26 10:13:21 GMT 2021


On Fri, Mar 26, 2021 at 9:34 AM Jakub Jelinek via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On Thu, Mar 25, 2021 at 11:36:37AM -0700, H.J. Lu via Gcc-patches wrote:
> > How can we move forward with it?  I'd like to resolve it in GCC 11.
>
> I think it is too late for GCC 11 for this.
> Especially if the solution would be that we change the behavior of existing
> attribute, we would need enough time to test everything in the wild that
> we don't break it badly,

But isn't the suggested change only going to make programs we reject now
with an error accepted or ICEing?  Thus, no program that works right now
should break.

Richard.

> even if we add new attributes that cover the
> previous behavior.  Only if we keep the behavior of existing attribute
> and add a new one with the new behavior it would be something that could
> be considered for GCC 11 IMNSHO but then you'd need to change the glibc
> headers in time too to buy into the new attribute.
> We need analysis of all GCC targets with target attribute support and
> handle them consistently.
>
>         Jakub
>


More information about the Gcc-patches mailing list