[PATCH] Ada: hashed container Cursor type predefined equality non-conformance

[Richard Wai]

Arno,

I appologise for making a mess of this final step. I have leared the errors
of my ways.

Below are the change log entries for this patch:

gcc/ada/Changelog:

2021-03-09  Richard Wai  <richard@annexi-strayline.com>

	* libgnat/a-cohase.ads (Cursor): Synchronize comments for the Cursor
	type definition to be consistent with identical definitions in other
	container packages. Add additional comments regarding the importance
of
	maintaining the "Position" component for predefined equality.
	* libgnat/a-cohama.ads (Cursor): Likewise.
	* libgnat/a-cihama.ads (Cursor): Likewise.
	* libgnat/a-cohase.adb (Find, Insert): Ensure that Cursor objects
	always have their "Position" component set to ensure predefined
	equality works as required.
	* libgnat/a-cohama.adb (Find, Insert): Likewise.
	* libgnat/a-cihama.adb (Find, Insert): Likewise.

gcc/testsuite/Changelog:

2021-03-09  Richard Wai <richard@annexi-strayline.com>

	* gnat.dg/containers2.adb: New test.


Thanks for this.

Richard

> -----Original Message-----
> From: Arnaud Charlet <charlet@adacore.com>
> Sent: March 9, 2021 10:51 AM
> To: Richard Wai <richard@annexi-strayline.com>
> Cc: gcc-patches@gcc.gnu.org; 'Bob Duff' <duff@adacore.com>; Arnaud
> Charlet <charlet@adacore.com>
> Subject: Re: [PATCH] Ada: hashed container Cursor type predefined equality
> non-conformance
> 
> > Oops, I wrote "effected" when I meant "affected". Of course, despite
> > reading it several times before sending, I only noticed it after
sending.
> >
> > Edited version:
> >
> > ---
> >
> > * libgnat/a-cohase.ads, libgnat/a-cohase.adb, libgnat/a-cohama.ads,
> > libgnat/a-cohama.adb, libgnat/a-cihama.ads, libgnat/a-cihama.adb:
> > Ensure that Cursor objects always have their "Position" component set
> > to ensure predefined equality works as required; synchronize comments
> > for the Cursor type defintion across affected packages, and add
> > comments to explain the importance of updating the Position component.
> > * testsuite/gnat.dg/containers2.adb: New regression test to ensure
> > that all hashed containers obey predefined equality requirements for
> Cursor objects.
> 
> OK. The commit log follows strict rules, and in particular you need to
list the
> functions (And types modified), e.g:
> 
> 	* libgnat/a-cohase.ads, libgnat/a-cohase.adb, libgnat/a-cohama.ads,
> 	libgnat/a-cohama.adb, libgnat/a-cihama.ads, libgnat/a-cihama.adb
> (Cursor,
> 	Insert, Find): ...
> 
> See https://gcc.gnu.org/codingconventions.html#ChangeLogs for more
> details.
> 
> OK with the above commit log amended.
> 
> Arno