[PATCH] Ada: hashed container Cursor type predefined equality non-conformance
Arnaud Charlet
charlet@adacore.com
Tue Mar 9 15:51:06 GMT 2021
> Oops, I wrote "effected" when I meant "affected". Of course, despite reading
> it several times before sending, I only noticed it after sending.
>
> Edited version:
>
> ---
>
> * libgnat/a-cohase.ads, libgnat/a-cohase.adb, libgnat/a-cohama.ads,
> libgnat/a-cohama.adb, libgnat/a-cihama.ads, libgnat/a-cihama.adb:
> Ensure that Cursor objects always have their "Position" component set to
> ensure predefined equality works as required; synchronize comments for the
> Cursor type defintion across affected packages, and add comments to explain
> the importance of updating the Position component.
> * testsuite/gnat.dg/containers2.adb: New regression test to ensure that all
> hashed containers obey predefined equality requirements for Cursor objects.
OK. The commit log follows strict rules, and in particular you need to list the
functions (And types modified), e.g:
* libgnat/a-cohase.ads, libgnat/a-cohase.adb, libgnat/a-cohama.ads,
libgnat/a-cohama.adb, libgnat/a-cihama.ads, libgnat/a-cihama.adb (Cursor,
Insert, Find): ...
See https://gcc.gnu.org/codingconventions.html#ChangeLogs for more details.
OK with the above commit log amended.
Arno
More information about the Gcc-patches
mailing list