[PATCH] Rearrange detection of temporary directory for NetBSD

Jeff Law jeffreyalaw@gmail.com
Tue Jun 29 15:15:50 GMT 2021



On 6/28/2021 4:45 PM, Gerald Pfeifer wrote:
> On Thu, 26 Mar 2020, Kamil Rytarowski wrote:
>> On 25.03.2020 23:36, Jeff Law wrote:
>>> I wouldn't mind dropping /usr/tmp.  That so antiquated that it'd be
>>> non- controversial.  Can you send that as a separate patch.
>> Behavior for !__NetBSD__ is out of interest.
> This is not a very useful approach in a collaborative project like GCC.
>
> Incremental changes (including cleanups) help and are a good way to get
> engaged, improve the overall code base, and gain support from others
> (who may not have any interest in the __NetBSD__ case, but be willing
> to collaborate).
>
> @Jeff, is the following what you had in mind?
>
> It passed testing on i686-unknown-freebsd12; okay to push?
>
> Gerald
>
>
> commit 8365565396cee65aeb6c2e4bfad74e095a3c388c
> Author: Gerald Pfeifer <gerald@pfeifer.com>
> Date:   Tue Jun 29 00:39:15 2021 +0200
>
>      libiberty: No longer use /usr/tmp
>      
>      /usr/tmp is antiquated and not present on decently modern systems.
>      Remove it from consideration when choosing a directory for temporary
>      files.
>      
>      libiberty:
>      
>      2021-06-29  Gerald Pfeifer  <gerald@pfeifer.com>
>      
>              * make-temp-file.c (usrtmp): Remove.
>              (choose_tmpdir): Remove use of usrtmp.
Yup.  This is fine.  You might consider updating the comment which 
references /usr/tmp in choose_tmpdir along the way.
jeff



More information about the Gcc-patches mailing list