[Ping^2, Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST

Tobias Burnus tobias@codesourcery.com
Mon Jun 21 12:30:21 GMT 2021


Any reason that you did not put it under
   gfortran.dg/coarray/
such that it is also run with -fcoarray=lib (-lcaf_single)?
I know that the issue only exists for single, but it also makes
sense to check that libcaf_single works ....

In that sense, I wonder whether also the other CO_* should be
checked in the testsuite as they are handled differently in
libcaf_... (but identical with -fcoarray=single).

Except for those two nits, it LGTM. Thanks!

Tobias

PS: The function is used by
     case GFC_ISYM_CO_BROADCAST:
     case GFC_ISYM_CO_MIN:
     case GFC_ISYM_CO_MAX:
     case GFC_ISYM_CO_REDUCE:
     case GFC_ISYM_CO_SUM:
and, with -fcoarray=single, errmsg is not touched
as stat is (unconditionally) 0 (success)..


On 19.06.21 13:23, Andre Vehreschild via Fortran wrote:
> PING!
>
> On Fri, 4 Jun 2021 18:05:18 +0200
> Andre Vehreschild <vehre@gmx.de> wrote:
>
>> Ping!
>>
>> On Fri, 21 May 2021 15:33:11 +0200
>> Andre Vehreschild <vehre@gmx.de> wrote:
>>
>>> Hi,
>>>
>>> the attached patch fixes an issue when calling CO_BROADCAST in
>>> -fcoarray=single mode, where the optional but non-present (in the calling
>>> scope) stat variable was assigned to before checking for it being not
>>> present.
>>>
>>> Regtests fine on x86-64-linux/f33. Ok for trunk?
>>>
>>> Regards,
>>>     Andre
>>
>
> --
> Andre Vehreschild * Email: vehre ad gmx dot de
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf


More information about the Gcc-patches mailing list