[PATCH] Improvements to fur_source interface class, enhanced stmt folding options.

Aldy Hernandez aldyh@redhat.com
Wed Jun 9 07:42:57 GMT 2021


> +range_query *
> +fur_edge::query ()
> +{
> +  return m_query;
> +}
> +
> +
> +// Instantiate a stmt based fur_source.
> +
> +
> +fur_stmt::fur_stmt (gimple *s, range_query *q)
> +{


I think you there should be one space between functions, not two.  You 
have a few of these throughout.

> +  m_stmt= s;

Space.

> +
> +// Retirenve range of EXPR as it occurs as a use on stmt M_STMT.
> +

Typo.

> +// This version of fur_source will pick a range from a stmt, and register
> +// also dependencies via a gori_compute object.  This is mostly an internal API.
> +

s/register also/also register/

> +// Instantiate a stmt based fur_source witrh a GORI object
s/witrh/with

> +inline
> +fur_depend::fur_depend (gimple *s, gori_compute *gori, range_query *q)
> +							      : fur_stmt (s, q)

Shouldn't that ":" be aligned further to the left?  Probably with the 
"r" in fur_depend.

> +// Get the next operand from the vector, ensure types are compatible,

Comma instead of period at the end.

> +// and edge or anywhere a derived classof fur_source wants.
>  

Typo in classof.

> +// via a range_of_Expr call on stmt S.
> +

typo in "E"

Thanks.
Aldy



More information about the Gcc-patches mailing list