[PATCH 02/57] Support scanning of build-time GC roots in gengtype

Richard Biener richard.guenther@gmail.com
Mon Jun 7 13:36:41 GMT 2021


On Mon, Jun 7, 2021 at 2:35 PM Bill Schmidt <wschmidt@linux.ibm.com> wrote:
>
> On 6/7/21 5:39 AM, Richard Sandiford wrote:
> > Bill Schmidt via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> >> On 5/20/21 5:24 PM, Segher Boessenkool wrote:
> >>> On Tue, May 11, 2021 at 11:01:22AM -0500, Bill Schmidt wrote:
> >>>> Hi!  I'd like to ping this specific patch from the series, which is the
> >>>> only one remaining that affects common code.  I confess that I don't
> >>>> know whom to ask for a review for gengtype; I didn't get any good ideas
> >>>> from MAINTAINERS.  If you know of a good reviewer candidate, please CC
> >>>> them.
> >>> Richard is listed as the "gen* on machine desc" maintainer, that might
> >>> be the closest to this.  cc:ed.
> >> Hi, Richard -- any thoughts on this patch?
> >>
> >> https://gcc.gnu.org/pipermail/gcc-patches/2021-April/568841.html
> > I don't really know gengtype.c, sorry.  (The gen* thing was for
> > the md generators, not genmatch and gengtype.)
> >
> > Richard
>
> OK, thanks, Richard!
>
> Richi, from git blame, it appears everyone that used to know about
> gengtype has moved on.

Ouch.

> Would you be able to give a quick peek at this?
> It's a pretty uninteresting patch, all in all. :-)

Some maybe obvious issue - what about DOS-style path hosts?
You seem to build ../ strings to point to parent dirs...  I'm not sure
what we do elsewhere - I suppose we arrange for appropriate
-I command line arguments?

Richard.

>
> Thanks,
> Bill
>


More information about the Gcc-patches mailing list