[PATCH v2 2/6] rs6000: Add tests for SSE4.1 "blend" intrinsics

Segher Boessenkool segher@kernel.crashing.org
Wed Jul 28 21:51:40 GMT 2021


Hi!

On Fri, Jul 16, 2021 at 08:50:18AM -0500, Paul A. Clarke wrote:
> Copy the tests for _mm_blend_pd, _mm_blendv_pd, _mm_blend_ps,
> _mm_blendv_ps from gcc/testsuite/gcc.target/i386.

You get less messy series in cases like this if you just put the tests
in the same patch as the code it tests (which works fine with Git by
default, it sorts everything in gcc/testsuite/ after everything in
gcc/config/ after all, so the important stuff is first in your patch).

> gcc/testsuite
> 	* gcc.target/powerpc/sse4_1-blendpd.c: Copy from gcc.target/i386.
> 	* gcc.target/powerpc/sse4_1-blendps-2.c: Likewise.
> 	* gcc.target/powerpc/sse4_1-blendps.c: Likewise.
> 	* gcc.target/powerpc/sse4_1-blendvpd.c: Likewise.

Well, they aren't exact copies, the dg-* statements are different (to
make it run only on a p8 or up, and enabling generating p8 code).  So
maybe say that?

Okay for trunk.  Thanks!


Segher


More information about the Gcc-patches mailing list