[PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

Maciej W. Rozycki macro@orcam.me.uk
Fri Jul 23 02:21:53 GMT 2021


On Fri, 9 Jul 2021, Richard Sandiford via Gcc-patches wrote:

> >> > > The "smallest fix" is simply adding -fno-inline into mips.exp. 
> >> > > However
> >> > > I don't like it because I agree with you that mips.exp shouldn't
> >> > > care
> >> > > about dg-options, at least don't do it too much.
> >> > As I said in the other message, I think the smallest fix is the way
> >> > to
> >> > go though.
> >> THanks for chiming in Richard.  I didn't know all the background
> >> here.   
> >> Let's just go with the small fix based on your recommendation.  We can
> >> always revisit if we keep running into issues in this code.
> >
> > Pushed at 3b33b113.
> 
> It looks like that was the originally posted patch though.  It probably
> wasn't very clear, but by smallest fix, I meant adding inline to:

 Xi, will you revert your commit that was not approved and apply the 
correct fix?

  Maciej


More information about the Gcc-patches mailing list