[PATCH 18/55] rs6000: Write output to the builtins init file, part 1 of 3

Segher Boessenkool segher@kernel.crashing.org
Tue Jul 20 23:51:55 GMT 2021


On Thu, Jun 17, 2021 at 10:19:02AM -0500, Bill Schmidt wrote:
> 2021-06-07  Bill Schmidt  <wschmidt@linux.ibm.com>
> 
> gcc/
> 	* config/rs6000/rs6000-gen-builtins.c (write_fntype): New
> 	callback function.
> 	(write_fntype_init): New stub function.
> 	(write_init_bif_table): Likewise.
> 	(write_init_ovld_table): New function.
> 	(write_init_file): Implement.

> +	  /* Check whether we have a "tf" token in this string, representing
> +	     a float128_type_node.  It's possible that float128_type_node is
> +	     undefined (occurs for -maltivec -mno-vsx, for example), so we
> +	     must guard against that.  */

Yeah, this is still a problem :-(

> +	  /* Similarly, look for decimal float tokens.  */
> +	  int dfp_found = (strstr (ovlds[i].fndecl, "dd") != NULL
> +			   || strstr (ovlds[i].fndecl, "td") != NULL
> +			   || strstr (ovlds[i].fndecl, "sd") != NULL);

Strange ordering?  It's not alphabetic, it's not by size -- is it
random?

> +	  /* The fndecl for an overload is arbitrarily the first one
> +	     for the overload.  We sort out the real types when
> +	     processing the overload in the gcc front end.  */

Same as before -- please put such comments in the generated file!

Okay for trunk.  Thanks!


Segher


More information about the Gcc-patches mailing list