[committed] libstdc++: Add noexcept to __replacement_assert [PR101429]

Jonathan Wakely jwakely@redhat.com
Fri Jul 16 14:38:03 GMT 2021


On Thu, 15 Jul 2021 at 19:47, Jonathan Wakely wrote:
>
>
>
> On Thu, 15 Jul 2021, 18:21 François Dumont via Libstdc++, <libstdc++@gcc.gnu.org> wrote:
>>
>> On 15/07/21 5:26 pm, Jonathan Wakely via Libstdc++ wrote:
>> > This results in slightly smaller code when assertions are enabled when
>> > either using Clang (because it adds code to call std::terminate when
>> > potentially-throwing functions are called in a noexcept function) or a
>> > freestanding or non-verbose build (because it doesn't use printf).
>> >
>> > Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
>> >
>> > libstdc++-v3/ChangeLog:
>> >
>> >       PR libstdc++/101429
>> >       * include/bits/c++config (__replacement_assert): Add noexcept.
>> >       [!_GLIBCXX_VERBOSE] (__glibcxx_assert_impl): Use __builtin_trap
>> >       instead of __replacement_assert.
>> >
>> > Tested powerpc64le-linux. Committed to trunk.
>> >
>> ChangeLog is talking about __builtin_trap but there is none in the
>> attached patch.
>
>
>
> Yes I already noticed that and mentioned it in the bugzilla PR. It uses __builtin_abort not __builtin_trap. I'll fix the ChangeLog file tomorrow after it gets generated.

Fixed in r12-2361

> The Git commit message will stay wrong though.



More information about the Gcc-patches mailing list