[committed] Skip asm goto test fails on hppa

Richard Sandiford richard.sandiford@arm.com
Tue Jan 19 12:52:46 GMT 2021


Hans-Peter Nilsson <hp@bitrange.com> writes:
> On Tue, 19 Jan 2021, Jakub Jelinek wrote:
>
>> On Mon, Jan 18, 2021 at 11:50:56PM -0500, Hans-Peter Nilsson wrote:
>> > On Mon, 18 Jan 2021, John David Anglin wrote:
>> > > The hppa target is a reload target and asm goto is not supported on reload targets.
>> > > Skip failing tests on hppa.
>> >
>> > IIUC the preferred term is "IRA target" or maybe "non-LRA
>> > target", as opposed to "LRA target".  The tests fail for
>> > cris-elf too, another IRA target, so I'd like to use that term
>> > when adjusting the dg-skip-if, hope you don't mind.
>> >
>> > But also, I'd like to xfail it instead for cris-elf, which adds
>> > a caveat: people might then think a "reload target" is not the
>> > same as an "IRA target", what with the different adjustments.
>>
>> I think "IRA target" is not the right term, all targets are IRA targets,
>> but only some are using LRA and others use the old reload.
>
> But, IRA isn't used when...

Not sure what was elided here, but the choices are IRA+reload, IRA+LRA,
or no RA at all.

FWIW, Dave's “reload target” sounded fine to me.  It seems a bit more
precise than “non-LRA target”, which if taken literally would include
no-RA targets.

> Whatever; LRA and non-LRA then.
> I'll call the suggested testsuite target-supports predicate
> "lra" (thanks Andreas S.; of course!), to be used negated here.

Sounds good.

Thanks,
Richard


More information about the Gcc-patches mailing list