[PATCH] libgomp/i386: Move syscall asms to static inline wrapper.
Jakub Jelinek
jakub@redhat.com
Thu Feb 11 19:10:00 GMT 2021
On Thu, Feb 11, 2021 at 07:44:53PM +0100, Uros Bizjak wrote:
> 2021-02-11 Uroš Bizjak <ubizjak@gmail.com>
>
> libgomp/
> * config/linux/x86/futex.h (__futex_wait): New static inline
> wrapper function. Correct output type to int and
> timeout type to void *.
> (__futex_wake): New static inline wrapper function.
> Correct output type to int.
> (futex_wait): Use __futex_wait.
> (futex_wake): Use __futex_wake.
>
> Uros.
> diff --git a/libgomp/config/linux/x86/futex.h b/libgomp/config/linux/x86/futex.h
> index 1e01b681401..1e5f9d4357d 100644
> --- a/libgomp/config/linux/x86/futex.h
> +++ b/libgomp/config/linux/x86/futex.h
> -static inline void
> -futex_wait (int *addr, int val)
> +static inline int
> +__futex_wait (int *uaddr, int futex_op, int val)
Please call the argument just addr rather than uaddr, there is no need
to stress that it is a user address, all pointers outside of kernel are user
addresses. And addr is consistent with all the other futex.h headers.
Ok for trunk with those changes.
Jakub
More information about the Gcc-patches
mailing list