[PATCH] libstdc++: Don't use reserved identifiers in simd headers

[Jonathan Wakely]

On 01/02/21 13:21 +0100, Rainer Orth wrote:
>Two simd tests FAIL on Solaris, both SPARC and x86:
>
>FAIL: experimental/simd/standard_abi_usable.cc -msse2 -O2 -Wno-psabi (test for excess errors)
>FAIL: experimental/simd/standard_abi_usable_2.cc -msse2 -O2 -Wno-psabi (test for excess errors)
>
>This happens because the simd headers use identifiers documented in the
>libstdc++ manual as reserved by system headers.
>
>Fixed as follows, tested on i386-pc-solaris2.11, sparc-sun-solaris2.11,
>and x86_64-pc-linux-gnu.
>
>Ok for master?

OK, thanks.


>As an aside, the use of vim: markers initially confused the hell out of
>me.  As an Emacs user, I rarely use vi for much more than a pager, but
>when I wanted to check the lines mentioned in the g++ errors, I had no
>idea what was going on or how to disable the folding enabled there:
>
>// vim: foldmethod=marker sw=2 noet ts=8 sts=2 tw=80
>
>I can't help but feel that this is just a personal preference and
>doesn't belong into the upstream code.
>
>For avoidance of doubt, I'd consider equivalent Emacs local variables
>equally inappropriate.

We do have Emacs mode lines in all the libstdc++ headers FWIW. I use a
modified copy of https://www.vim.org/scripts/script.php?script_id=3381
to parse those modelines and set Vim config like sw=2 noet ts=2 etc.
when it sees them. So I don't need vim: lines, because the Emacs ones
work for me.

I agree with removing the vim: lines if Matthias is happy to. The
foldmethod is definitely awkward if that's not your preference.