[PATCH] tree-optimization/102142 - fix typo in loop BB reduc cost adjustment

Richard Biener rguenther@suse.de
Tue Aug 31 10:26:54 GMT 2021


This fixes a typo in the condition guarding the cleanup of the
visited flag of costed scalar stmts.

Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.

2021-08-31  Richard Biener  <rguenther@suse.de>

	PR tree-optimization/102142
	* tree-vect-slp.c (vect_bb_vectorization_profitable_p): Fix
	condition under which to unset the visited flag.

	* g++.dg/torture/pr102142.C: New testcase.
---
 gcc/testsuite/g++.dg/torture/pr102142.C | 9 +++++++++
 gcc/tree-vect-slp.c                     | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)
 create mode 100644 gcc/testsuite/g++.dg/torture/pr102142.C

diff --git a/gcc/testsuite/g++.dg/torture/pr102142.C b/gcc/testsuite/g++.dg/torture/pr102142.C
new file mode 100644
index 00000000000..8e3ea5d96b5
--- /dev/null
+++ b/gcc/testsuite/g++.dg/torture/pr102142.C
@@ -0,0 +1,9 @@
+/* { dg-do compile } */
+
+extern short arr_597[];
+extern bool arr_601[];
+int test_var_13;
+void test(short arr_391[][9][2][2]) {
+  for (int i_60 = 0; i_60 < 11; i_60 += test_var_13)
+    arr_597[22] = arr_601[i_60] = arr_391[0][0][1][4];
+}
diff --git a/gcc/tree-vect-slp.c b/gcc/tree-vect-slp.c
index 4ca24408249..fa3566f3d06 100644
--- a/gcc/tree-vect-slp.c
+++ b/gcc/tree-vect-slp.c
@@ -5396,7 +5396,7 @@ vect_bb_vectorization_profitable_p (bb_vec_info bb_vinfo,
 
   /* Unset visited flag.  This is delayed when the subgraph is profitable
      and we process the loop for remaining unvectorized if-converted code.  */
-  if (orig_loop && !profitable)
+  if (!orig_loop || !profitable)
     FOR_EACH_VEC_ELT (scalar_costs, i, cost)
       gimple_set_visited  (cost->stmt_info->stmt, false);
 
-- 
2.31.1


More information about the Gcc-patches mailing list