[PATCH][pushed] Add -fprofile-reproducible=parallel-runs to STAGEfeedback_CFLAGS to Makefile.tpl.

Martin Liška mliska@suse.cz
Tue Aug 31 06:54:46 GMT 2021


On 8/31/21 01:03, Gleb Fotengauer-Malinovskiy wrote:
> On Mon, Aug 30, 2021 at 10:13:21AM +0200, Martin Liška wrote:
>> On 8/27/21 19:45, Gleb Fotengauer-Malinovskiy wrote:
>>> Hi,
>>>
>>> On Thu, Mar 11, 2021 at 04:19:51PM +0100, Martin Liška wrote:
>>>> Pushed as obvious, the original change was done
>>>> in g:e05a117dc4b98f3ac60851608f532ba7cee7343a.
>>>>
>>>> Martin
>>>>
>>>> ChangeLog:
>>>>
>>>> 	* Makefile.tpl: The change was done Makefile.in which
>>>> 	is generated file.
>>>> ---
>>>>     Makefile.tpl | 2 +-
>>>>     1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/Makefile.tpl b/Makefile.tpl
>>>> index 3b88f351d5b..6e0337fb48f 100644
>>>> --- a/Makefile.tpl
>>>> +++ b/Makefile.tpl
>>>> @@ -488,7 +488,7 @@ STAGEprofile_TFLAGS = $(STAGE2_TFLAGS)
>>>>     STAGEtrain_CFLAGS = $(filter-out -fchecking=1,$(STAGE3_CFLAGS))
>>>>     STAGEtrain_TFLAGS = $(filter-out -fchecking=1,$(STAGE3_TFLAGS))
>>>>     
>>>> -STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use
>>>> +STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use -fprofile-reproducible=parallel-runs
>>>
>>> Did you mean to add -fprofile-reproducible flag to STAGEprofile_CFLAGS
>>> instead?
>>
>> No.
>>
>>> I suppose this flag doesn't mean anything without
>>> -fprofile-generate, which is passed through STAGEprofile_CFLAGS.
>>
>> The flag -fprofile-reproducible is used when we use a collected profile, so it works
>> *only* with -fprofile-use flag.
> 
> Thank you for the answer, now I see how it works.

Good.

> 
> I think that it means that the documentation is rather misleading about
> this flag:
> 
>   '-fprofile-reproducible=[multithreaded|parallel-runs|serial]'
>        Control level of reproducibility of profile gathered by
>        '-fprofile-generate'. [...]

Well, feel free to send a patch that can improve the wording.

Cheers,
Martin

> 
> It convinced me that this flag changes the way the code is instrumented
> for profile generation.  The rest of it convinced me even more, actually.
> 
>> Thanks for heads up!
>> Cheers,
>> Martin
>>
>>>
>>> Thanks,
>>>
> 



More information about the Gcc-patches mailing list