[PING] Re: [PATCH] configure, jit: Allow for 'make check-gcc-jit'.

Iain Sandoe iain@sandoe.co.uk
Fri Aug 27 13:00:08 GMT 2021


+Jeff

(it’s probably borderline obvious - but in the top level Makefile .. so)

> On 17 Aug 2021, at 21:53, David Malcolm <dmalcolm@redhat.com> wrote:
> 
> On Tue, 2021-08-17 at 19:59 +0100, Iain Sandoe wrote:
>> Hi,
>> 
>> For those of us who habitually build Ada, it’s convenient to 
>> have a way of running individual test suites without invoking
>> the acats tests…
>> 
>> being able to do “make check-gcc-jit” from the top level is very
>> useful when debugging jit testsuite issues.
>> 
>> one can do "cd gcc ; make check-jit "- but this doesn’t seem 100%
>> identical since the invocations from the top level set the host
>> exports first.
>> 
>> … the patch itself is trivial / obvious - I am just curious as to
>> whether there was a reason for omitting it so far?
> 
> Probably just a mistake on my part; Makefile glue is not my strongest
> skill.
> 
>> 
>> If not, 
>> 
>> OK for master?
> 
> Sounds OK to me - but then again, Makefile glue is not my strongest
> skill, so not sure if I'm qualified to approve this.
> 
>> 
>> thanks
>> Iain
>> 
>> ====
>> 
>> 
>> This is a convenience feature that allows the user to
>> do "make check-gcc-jit" at the top level of the build
>> to check that facility in isolation from others.
>> 
>> Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
>> 
>> ChangeLog:
>> 
>>         * Makefile.def: Add a jit check target for the jit
>>         language.
>>         * Makefile.in: Regenerate.
>> ---
>>  Makefile.def | 1 +
>>  Makefile.in  | 8 ++++++++
>>  2 files changed, 9 insertions(+)
>> 
>> diff --git a/Makefile.def b/Makefile.def
>> index fbfdb6fee08..7cbeca5b181 100644
>> --- a/Makefile.def
>> +++ b/Makefile.def
>> @@ -654,6 +654,7 @@ languages = { language=go;  gcc-check-
>> target=check-go;
>>                                 lib-check-target=check-gotools; };
>>  languages = { language=d;      gcc-check-target=check-d;
>>                                 lib-check-target=check-target-
>> libphobos; };
>> +languages = { language=jit;    gcc-check-target=check-jit; };
>>  
>>  // Toplevel bootstrap
>>  bootstrap_stage = { id=1 ; };



More information about the Gcc-patches mailing list