[PATCH 15/34] rs6000: Execute the automatic built-in initialization code

Segher Boessenkool segher@kernel.crashing.org
Fri Aug 27 12:49:49 GMT 2021


On Fri, Aug 27, 2021 at 07:35:05AM -0500, Bill Schmidt wrote:
> On 8/26/21 6:15 PM, Segher Boessenkool wrote:
> >On Thu, Jul 29, 2021 at 08:31:02AM -0500, Bill Schmidt wrote:
> >>+  /* Execute the autogenerated initialization code for builtins.  */
> >>+  rs6000_autoinit_builtins ();
> >The name "autoinit" isn't so great (what "self" does this "auto" refer
> >to?), but perhaps some later patch fixes this up?  It is minor of
> >course, but the bigger something is, the better name that it deserves.
> >Names shape thoughts, and we should make the architecture of our code as
> >clear as possible.
> 
> Well, "autoinit" was meant to mean "automated initialization."  But I 
> take your point.

*Everything* GCC does is "automated" in some way, the term is
meaningless :-)

> What would you say to "rs6000_init_generated_builtins"?

That is fine.

Thanks!


Segher


More information about the Gcc-patches mailing list