Ping: [PATCH] diagnostics: Support for -finput-charset [PR93067]

Lewis Hyatt lhyatt@gmail.com
Tue Aug 24 23:28:50 GMT 2021


On Tue, Aug 24, 2021 at 6:51 PM David Malcolm <dmalcolm@redhat.com> wrote:
>
> On Tue, 2021-08-24 at 08:17 -0400, Lewis Hyatt wrote:
> > Hello-
> >
> > I thought it might be a good time to check on this patch please?
> > Thanks!
> > https://gcc.gnu.org/pipermail/gcc-patches/2021-July/576449.html
> >
> > -Lewis
>
> I went through that latest version of the patch and have no further
> suggestions - I like the changes you made to incorporate the changes I
> had made to input.c.
>
> The latest version of the patch is OK for trunk.
>
> It might be an idea to rebase it and retest it before pushing it, to
> make sure nothing significant has changed in the last few weeks.
>
> Thanks for your work on this, and sorry again for the delay in
> reviewing it.
>
> Dave
>
>

OK great, thanks for your time. I will push after retesting.

BTW, do you think it would be worthwhile to work on the other half of
encoding support, i.e. translating from UTF-8 to the user's locale,
when outputting diagnostics? I have probably 90% of a patch that does
this, however it complexifies things a bit and I am not sure if it is
really worth the trouble. What is rather manageable (that my patch in
progress does now) is to replace non-translatable characters with
something like UCN escapes. What is not so easy, is to do this and
preserve the alignment of carets and label lines and such... this
requires making the display width of a character also
locale-dependent, which concept doesn't exist currently. Adding that
feels like a lot of complication for what would be a little-used
feature... Anyway, if you think a patch that does the translation
without preserving the alignment would be useful, I could finish it up
and send it. Otherwise I was kinda inclined to forget about it.
Thanks!

-Lewis


More information about the Gcc-patches mailing list