[PATCH 47/55] rs6000: Builtin expansion, part 4

Bill Schmidt wschmidt@linux.ibm.com
Thu Aug 12 16:17:33 GMT 2021


Hi Segher,

On 8/3/21 7:34 PM, Segher Boessenkool wrote:
> Whoops, I forgot some stuff:
>
> On Tue, Jul 27, 2021 at 04:06:49PM -0500, will schmidt wrote:
>> On Thu, 2021-06-17 at 10:19 -0500, Bill Schmidt via Gcc-patches wrote:
>>>   static rtx
>>>   ldv_expand_builtin (rtx target, insn_code icode, rtx *op, machine_mode tmode)
>>>   {
>>> +  rtx pat, addr;
>>> +  bool blk = (icode == CODE_FOR_altivec_lvlx
>>> +	      || icode == CODE_FOR_altivec_lvlxl
>>> +	      || icode == CODE_FOR_altivec_lvrx
>>> +	      || icode == CODE_FOR_altivec_lvrxl);
>>> +
>>> +  if (target == 0
>>> +      || GET_MODE (target) != tmode
>>> +      || ! (*insn_data[icode].operand[0].predicate) (target, tmode))
>> No space after "!" ?  (here and later on 'pat'.).
> It can be written as just
>        || !insn_data[icode].operand[0].predicate (target, tmode))
> even.  The * is completely optional, and you don't need the extra parens
> without it.


Agreed.  This is copied from an idiom that exists throughout the file, 
so I plan to handle this by adding a style patch to clean it up everywhere.

Bill

>
>
> Segher


More information about the Gcc-patches mailing list