[Patch v3 Fortran] Fix c_float128 and c_float128_complex on targets with 128-bit long double.

Tobias Burnus tobias@codesourcery.com
Wed Aug 11 08:05:58 GMT 2021


On 11.08.21 00:46, Sandra Loosemore wrote:
> On 8/10/21 2:29 AM, Tobias Burnus wrote:
>>
>> [snip]
>>
>> To conclude: I like the code changes (LGTM); the
>> '__float128' -> 'TFmode' comment change also matches the code.
>>
>> However, I think both longer comments need to be updated.
>
> OK.  I used your wording verbatim for the first one.  For the second
> one, I'm still pretty confused as I think it is at least theoretically
> possible on PowerPC to have a target with 64-bit long double (AIX?)
> that also supports the __ibm128 format, and it would be wrong to
> assume that *any* 128-bit mode that's not long double is IEEE.  So I
> decided the best thing is just to replace the FIXME with a pointer to
> the issue I opened yesterday
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101835

LGTM – but ...

> +      /* See PR101835.  */

... I wonder whether your PR reference should have a TODO or FIXME
prefix – or a "for some issue" suffix. Currently, it can be read as if
the PR describes why the code was added – and not for questioning the code.

Tobias

PS: I added some more notes to the PR + extended the subject to make it
easier to find.

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955


More information about the Gcc-patches mailing list