[OpenACC] Extract 'pass_oacc_loop_designation' out of 'pass_oacc_device_lower' (was: [PATCH 1/4] openacc: Middle-end worker-partitioning support)

Julian Brown julian@codesourcery.com
Fri Aug 6 10:20:58 GMT 2021


On Thu, 29 Jul 2021 09:49:05 +0200
Thomas Schwinge <thomas@codesourcery.com> wrote:

> >  namespace {
> >  
> > +const pass_data pass_data_oacc_loop_designation =
> > +{
> > +  GIMPLE_PASS, /* type */
> > +  "oaccloops", /* name */
> > +  OPTGROUP_OMP, /* optinfo_flags */
> > +  TV_NONE, /* tv_id */
> > +  PROP_cfg, /* properties_required */
> > +  0 /* Possibly PROP_gimple_eomp.  */, /* properties_provided */
> > +  0, /* properties_destroyed */
> > +  0, /* todo_flags_start */
> > +  TODO_update_ssa | TODO_cleanup_cfg
> > +  | TODO_rebuild_alias, /* todo_flags_finish */
> > +};  
> 
> Do you remember why you added 'TODO_rebuild_alias' here?
> 'pass_oacc_device_lower' doesn't have it, and neither does
> 'pass_oacc_loop_designation' in your original (2017-11-27) internal
> gcn/master branch commit 81ee7ef64cdfa47c01f24c79b8ebd03242c9f3eb
> "Split device-lowering/gimple workers into three passes".  So I
> removed that -- but please do tell if there is a reason to keep it.

I do not :-). My suspicion is that it was leftover debug code, or
possibly the result of a bad merge.

(Another possibility is that the alias information needs updating when
we change the address space of certain entities during gimple rewriting
for worker partitioning -- but this is the wrong place for that, I
think?).

Thanks,

Julian


More information about the Gcc-patches mailing list