[PATCH] rs6000: Fix restored rs6000_long_double_type_size.

Martin Liška mliska@suse.cz
Thu Aug 5 12:05:24 GMT 2021


On 7/23/21 7:57 PM, Segher Boessenkool wrote:
> Hi!
> 
> On Fri, Jul 23, 2021 at 07:47:54AM +0200, Martin Liška wrote:
>> On 7/12/21 7:20 PM, Segher Boessenkool wrote:
>>>>>> +static __attribute__ ((optimize ("-fno-stack-protector"))) __typeof
>>>>>> (f) *
>>>>>
>>>>> -fno-stack-protector is default.
>>>>
>>>> Yes, but one needs an optimize attribute in order to trigger
>>>> cl_target_option_save/restore
>>>> mechanism.
>>>
>>> So it behaves differently if you select the default than if you do not
>>> select anything?  That is wrong, no?
>>
>> Sorry, I don't get your example, please explain it.
> 
> If -mbork is the default, the coompiler whould behave the same if you
> invoke it with -mbork as when you do not.  And the optimize attribute
> should work exactly the same as command line options.

Ah, got your point. All right, let's use then 'optimize(1)'.

Is it fine with the adjustment?
Cheers,
Martin

> 
> Or perhaps you are saying you have this in the testcase only to exercise
> the option save/restore code paths?  Please document that then, in the
> testcase.
> 
> 
> Segher
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-rs6000-Fix-restored-rs6000_long_double_type_size.patch
Type: text/x-patch
Size: 2237 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20210805/e3db2e7e/attachment.bin>


More information about the Gcc-patches mailing list