Disable modref for ipa-pta-13.c testcase

Richard Biener richard.guenther@gmail.com
Fri Sep 25 11:19:31 GMT 2020


On Fri, Sep 25, 2020 at 1:04 PM Jan Hubicka <hubicka@ucw.cz> wrote:
>
> Hi,
> parameter tracking in ipa-modref causes failure of ipa-pta-13 testcase.
> In partiuclar the check for "= x;" in fre3 is failing since we optimize
> it out in fre1.  As far as I can tell this is correct transform because
> ipa-modref propagates the fact that the call is passed pointer to y.
> Comment speaks of missed optimization, so I gues sit is OK to disable
> modref here so we still test whatever this was testing before?
>
Hmm, I guess so.  Ideally both local and local_address_taken would
be noipa but then IPA PTA wouldn't apply either ;)  So yes, OK to
disable modref.

Richard.

> Honza
>
> gcc/testsuite/ChangeLog:
>
> 2020-09-25  Jan Hubicka  <hubicka@ucw.cz>
>
>         * gcc.dg/ipa/ipa-pta-13.c: Disable ipa-modref.
>
> diff --git a/gcc/testsuite/gcc.dg/ipa/ipa-pta-13.c b/gcc/testsuite/gcc.dg/ipa/ipa-pta-13.c
> index 93dd87107cc..e7bf6d485a4 100644
> --- a/gcc/testsuite/gcc.dg/ipa/ipa-pta-13.c
> +++ b/gcc/testsuite/gcc.dg/ipa/ipa-pta-13.c
> @@ -1,5 +1,5 @@
>  /* { dg-do link } */
> -/* { dg-options "-O2 -fipa-pta -fdump-ipa-pta2-details -fdump-tree-fre3 -fno-ipa-icf" } */
> +/* { dg-options "-O2 -fipa-pta -fdump-ipa-pta2-details -fdump-tree-fre3 -fno-ipa-icf -fno-ipa-modref" } */
>
>  static int x, y;
>


More information about the Gcc-patches mailing list