[Patch] LTO: Force externally_visible for offload_vars/funcs (PR97179)

[Tobias Burnus]

I think I screwed up with testing – it seem now as if does not work like
this, but I need to recheck.

Tobias

On 9/23/20 4:23 PM, Tobias Burnus wrote:
> On 9/23/20 3:10 PM, Richard Biener wrote:
>
>> On Wed, 23 Sep 2020, Richard Biener wrote:
>>> LTRANS usually makes the symbols hidden, not local.
> Could also be – whatever the 'nm' output means.
>>> So are you
>>> sure this isn't a target bug (hidden symbols not implemented
>>> but the host compiler obviously having checked that but assuming
>>> the target behaves the same as the host) or a linker bug?
>
> Unlikely, I assume the Linux x86-64 linker is rather well tested.
> As written this is the host – just the offloading symbol table is
> device specific.
>
>> See lto/lto-partition.c:promote_symbol btw.
>
> Thanks for the pointer; it pointed me to node->externally_visible,
> which does the trick :-)
>
> Thus, next try – which a patch I like much better!
>
> Tobias
>
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter