[PATCH 3/5] Add DWARF5 variants of assembly scan tests that use DW_FORM_implicit_const

[Mark Wielaard]

On Mon, 2020-08-24 at 22:26 +0200, Mark Wielaard wrote:
> On Mon, Aug 24, 2020 at 07:44:27PM +0200, Jakub Jelinek wrote:
> > On Mon, Aug 24, 2020 at 02:56:56PM +0200, Mark Wielaard wrote:
> > > Some DWARF tests scan the assembly output looking for constant values.
> > > When using DWARF5 those constants might use DW_FORM_implicit_const,
> > > which are output (in the comments) after the attribute instead of
> > > before. To make sure these tests work introduce a -gdwarf-5 variant
> > > of these tests and explicitly use -gdwarf-2 for the original.
> > 
> > I just wonder if we want to use -gdwarf-2 rather than -gdwarf-4 in the
> > original, -gdwarf-5 has been the default for a couple of years and thus
> > that is what those testshave been compiled with.
> 
> I used -gdwarf-2 because I thought that was still the default for some
> arches/platforms. And they pass with -gdwarf-2.
> 
> > Also not sure about the -dwarf5 suffixes, couldn't we say just use
> > pr41445-{7,8}.c, inline-var-2.C or inline3.c (or whatever next number
> > with the same prefix is still unused)?
> 
> Sure, if that is a better naming scheme I'll rename them.

Here is the adjusted patch.

gcc/testsuite/ChangeLog:

        * gcc.dg/debug/dwarf2/inline2.c: Add -gdwarf-2.
        * g++.dg/debug/dwarf2/inline-var-1.C: Likewise.
        * gcc/testsuite/gcc.dg/debug/dwarf2/pr41445-5.c: Likewise.
        * gcc/testsuite/gcc.dg/debug/dwarf2/pr41445-6.c: Likewise.
        * gcc.dg/debug/dwarf2/inline6.c: New variant with -gdwarf-5.
        * g++.dg/debug/dwarf2/inline-var-3.C: Likewise.
        * gcc/testsuite/gcc.dg/debug/dwarf2/pr41445-7.c: Likewise.
        * gcc/testsuite/gcc.dg/debug/dwarf2/pr41445-8.c: Likewise.

OK to commit?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-DWARF5-variants-of-assembly-scan-tests-that-use-.patch
Type: text/x-patch
Size: 10635 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20200917/53cec708/attachment.bin>