c++: local-scope OMP UDR reductions have no template head

Nathan Sidwell nathan@acm.org
Wed Sep 16 18:38:22 GMT 2020


On 9/16/20 2:31 PM, Jakub Jelinek wrote:
> On Wed, Sep 16, 2020 at 02:11:32PM -0400, Nathan Sidwell wrote:
>> Jakub,
>> are you ok with the bool return from cp_check_omp_declare_reduction? That
>> seemed like the least invasive change.
>>
>> This corrects the earlier problems with removing the template header
>> from local omp reductions.  And it uncovered a latent bug.  When we
>> tsubst such a decl, we immediately tsubst its body.
>> cp_check_omp_declare_reduction gets a success return value to gate
>> that instantiation.
>>
>> udr-2.C	got a further error, as	the omp	checking machinery doesn't
>> appear to turn the reduction into an error mark	when failing.  I
>> didn't dig into that further.  udr-3.C appears to have been invalid
>> and accidentally worked.
> 
> The attached patch doesn't match the ChangeLog...

here's the right one,  problem with ordering by time or name :(

nathan

-- 
Nathan Sidwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: omp-udr-inst.diff
Type: text/x-patch
Size: 9778 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20200916/3d476ebb/attachment.bin>


More information about the Gcc-patches mailing list