[PATCH, rs6000] testsuite fixup pr96139 tests

Segher Boessenkool segher@kernel.crashing.org
Fri Sep 11 17:37:14 GMT 2020


Hi!

On Fri, Sep 11, 2020 at 09:44:54AM -0500, will schmidt wrote:
>       As reported, the recently added pr96139 tests will fail on older targets
>       because the tests are missing the appropriate -mvsx or -maltivec options.
>       This adds the options and clarifies the dg-require statements.

>     gcc/testsuite/ChangeLog:
>         * gcc.target/powerpc/pr96139-a.c: specify -mvsx option and require.
>         * gcc.target/powerpc/pr96139-a.c: specify -mvsx option and require.
>         * gcc.target/powerpc/pr96139-a.c: specify -maltivec option and require.

(Capital "S" on each line.)
("and require" isn't clear...  "dg-require"?)
(And the files are -a, -b, -c).

> diff --git a/gcc/testsuite/gcc.target/powerpc/pr96139-a.c b/gcc/testsuite/gcc.target/powerpc/pr96139-a.c
> index b3daee4..12a3383 100644
> --- a/gcc/testsuite/gcc.target/powerpc/pr96139-a.c
> +++ b/gcc/testsuite/gcc.target/powerpc/pr96139-a.c
> @@ -1,9 +1,9 @@
>  /* { dg-do compile } */
> -/* { dg-options "-O2 -Wall -m32" } */
> +/* { dg-options "-O2 -Wall -m32 -mvsx" } */
>  /* { dg-require-effective-target ilp32 } */
> -/* { dg-require-effective-target powerpc_altivec_ok } */
> +/* { dg-require-effective-target powerpc_vsx_ok } */

This uses vector long long.  Okay.

> --- a/gcc/testsuite/gcc.target/powerpc/pr96139-b.c
> +++ b/gcc/testsuite/gcc.target/powerpc/pr96139-b.c

Ditto.

> diff --git a/gcc/testsuite/gcc.target/powerpc/pr96139-c.c b/gcc/testsuite/gcc.target/powerpc/pr96139-c.c
> index 2464b8d..3ada260 100644
> --- a/gcc/testsuite/gcc.target/powerpc/pr96139-c.c
> +++ b/gcc/testsuite/gcc.target/powerpc/pr96139-c.c
> @@ -1,7 +1,7 @@
>  /* { dg-do run } */
> -/* { dg-options "-O2 -Wall" } */
> +/* { dg-options "-O2 -Wall -maltivec" } */
>  /* { dg-require-effective-target powerpc_altivec_ok } */

But this one as well, why does it not need VSX like the rest?


Segher


More information about the Gcc-patches mailing list