[PATCH] arm: Fix up arm_override_options_after_change_1

[Jeff Law]

On Thu, 2020-09-10 at 14:11 +0000, Kyrylo Tkachov wrote:
> Hi Jakub,
> 
> > -----Original Message-----
> > From: Jakub Jelinek <jakub@redhat.com>
> > Sent: 10 September 2020 09:51
> > To: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>; Kyrylo Tkachov
> > <Kyrylo.Tkachov@arm.com>; gcc-patches@gcc.gnu.org
> > Subject: [PATCH] arm: Fix up arm_override_options_after_change_1
> > 
> > On Tue, Sep 08, 2020 at 10:45:12AM +0200, Jakub Jelinek via Gcc-patches
> > wrote:
> > > Looking further at arm_override_options_after_change_1, it also seems to
> > be
> > > incorrect, rather than testing
> > > !opts->x_str_align_functions
> > > it should be really testing
> > > !opts_set->x_str_align_functions
> > > and get &global_options_set or similar passed to it as additional opts_set
> > > argument.  That is because otherwise the decision will be sticky, while it
> > > should be done whenever use provided -falign-functions but didn't provide
> > > -falign-functions= (either on the command line, or through optimize
> > > attribute or pragma).
> > 
> > Here is a fix for that (incremental change on top of the previous patch).
> > Bootstrapped/regtested on armv7hl-linux-gnueabi, ok for trunk?
> 
> This looks ok to me.
> Please commit to master so we can get some wider testing before backporting.
FWIW, I've done about a dozen package builds in Fedora with this patch to verify
it fixes the neon vs lto issues.  It's far from wide testing though ;-)  I've
asked Jakub to include it in the next GCC build he does for Fedora so that we can
remove those LTO opt-outs.

jeff
>