[PATCH] Support the new ("v0") mangling scheme in rust-demangle.

[Ian Lance Taylor]

On Wed, Oct 28, 2020 at 3:22 PM Nikhil Benesch via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> I think it is mostly a matter of snagging some of Ian's limited time.
> I suspect it is still worthwhile to try to get the original patch
> reviewed and merged, because then any follow-up changes for const
> generics support will be smaller and easier to review.

Yeah, it's not a good idea for me to be a blocker for changes to Rust code.

I took a quick look at the original patch.  The calls to sprintf
should use snprintf instead.

Other than that it seems fine though I have no idea whether it's correct.

Ian



> On Wed, Oct 28, 2020 at 5:48 PM Eduard-Mihai Burtescu <eddyb@lyken.rs> wrote:
> >
> > FWIW, the patch has become slightly outdated compared to the Rust upstream, so if someone wants to review it I should prepare a new version.
> >
> > The changes would be for the MVP version of "const generics" (Rust's equivalent to C++ templates with value parameters, enabling e.g. types like `CustomArray<T, 123>`), which supports a few different kinds of primitive values, whereas the original patch only handled unsigned integers.
> >
> > Thanks,
> > - Eddy B.
> >
> > On Wed, Oct 28, 2020, at 23:25, Nikhil Benesch wrote:
> > > On 10/28/20 5:22 PM, Nikhil Benesch wrote:
> > > > Ian, are you able to review this? I saw that you reviewed many of the
> > > > prior changes to the Rust demangler.
> > > >
> > > > If not, can you suggest someone who can?
> > > >
> > > > Thanks very much.
> > > > Nikhil
> > >
> > > I seem to have failed to convince my email client to set the appropriate
> > > reply to headers. This is the patch to which I was referring:
> > >
> > > https://gcc.gnu.org/pipermail/gcc-patches/2020-March/542488.html
> > >