[RS6000] float128-type-2.c unsupported

Segher Boessenkool segher@kernel.crashing.org
Wed Oct 28 18:44:54 GMT 2020


On Wed, Oct 28, 2020 at 09:18:35PM +1030, Alan Modra wrote:
> >From e7ce33cef478a826a2fe4e110b43b49586ef2438 Mon Sep 17 00:00:00 2001
> From: Alan Modra <amodra@gmail.com>
> Date: Wed, 28 Oct 2020 15:57:57 +1030
> Subject: 
> 
> I noticed this test is unsupported on power10 when looking through
> test logs.  There seems no reason why that should be the case, ie.
> likely the target test was meant to be powerpc64*-*-linux*.  And that
> simplifies down further.

The target name does not tell you if you are doing a -m32 or a -m64
build; both powerpc-linux and powerpc64-linux can build both 32-bit and
64-bit just fine (and hopefully identically).  Having target powerpc64*
is basically always wrong.

> diff --git a/gcc/testsuite/gcc.target/powerpc/float128-type-1.c b/gcc/testsuite/gcc.target/powerpc/float128-type-1.c
> index 13152ac7c26..53f9e357535 100644
> --- a/gcc/testsuite/gcc.target/powerpc/float128-type-1.c
> +++ b/gcc/testsuite/gcc.target/powerpc/float128-type-1.c
> @@ -1,4 +1,4 @@
> -/* { dg-do compile { target { powerpc64*-*-linux* && lp64 } } } */
> +/* { dg-do compile { target { *-*-linux* && lp64 } } } */
>  /* { dg-require-effective-target powerpc_p8vector_ok } */
>  /* { dg-options "-mdejagnu-cpu=power8 -O2 -mno-float128" } */
>  
> diff --git a/gcc/testsuite/gcc.target/powerpc/float128-type-2.c b/gcc/testsuite/gcc.target/powerpc/float128-type-2.c
> index 5644281c3d4..02dbad1fa4f 100644
> --- a/gcc/testsuite/gcc.target/powerpc/float128-type-2.c
> +++ b/gcc/testsuite/gcc.target/powerpc/float128-type-2.c
> @@ -1,4 +1,4 @@
> -/* { dg-do compile { target { powerpc64-*-linux* && lp64 } } } */
> +/* { dg-do compile { target { *-*-linux* && lp64 } } } */
>  /* { dg-require-effective-target powerpc_p9vector_ok } */
>  /* { dg-options "-mdejagnu-cpu=power9 -O2 -mno-float128" } */

Your patch is fine though, modulo what David said.  If there is some
selector you can use (or you can make one) that is much preferred.  But
since this patch is strictly an improvement already, it is okay for
trunk (if the 2nd works on powerpc64le-linux of course ;-) )  Thanks!

(Improving it to test on exactly the right targets would be nice :-) )


Segher


More information about the Gcc-patches mailing list