[patch] Introduce vxworks7r2 support for ppc and ppc64
Olivier Hainque
hainque@adacore.com
Wed Oct 21 10:30:52 GMT 2020
Hi Segher!
> On 20 Oct 2020, at 22:06, Segher Boessenkool <segher@kernel.crashing.org> wrote:
>
>> + # Wind River 7 post SR0600 is mostly like Linux so we setup
>> + # out config in a very similar fashion and adjust to a few
>> + # specificities.
>
> "our config"?
>
>> + - Starting with VxWorks 7 (post SR600), the system environment
>> + was made extremely similar to GNU/Linux and this toolchain is
>> + builtin on top of the corresponding header files. */
>
> "built on top"?
Indeed.
>> +/****************************
>> + * Common definitions first *
>> + ****************************/
>
> We don't use such decorated comments in GCC. But it is your header file
> of course :-)
Hmm, I’d really like to keep some visible separation for the
sections because it’s pretty dense overall and I think hard to
read without some high level hints about the general organization.
There are (a few, agreed :) instances of sectioning in other
sources, tree-core.h or tree-vectorizer.h for example, with a
different style though. I think I’ll adjust to one of these.
> I don't see anything wrong with the actual code itself, fwiw :-)
Great, feedback appreciated, thanks!
Next in line specific to rs6000 are a couple of suggestions
for updates in the testsuite (wrt fpic and dfp).
Regards,
Olivier
More information about the Gcc-patches
mailing list