Re: PING – Re: [Patch] collect-utils.c, lto-wrapper + mkoffload: Improve -save-temps filename

[Tobias Burnus]

On 10/20/20 11:27 AM, Richard Biener wrote:

> OK.

Missed two things – a copy'n'paste issue using the wrong variable and to
update a testcase, adding the newly added dump files there.

Committed as obvious in r11-4132-g6267bb7a11f53381d77b2c0a6193fcb9115d2b30

Tobias

On 10/13/20 9:37 PM, Tobias Burnus wrote:
>>> This patch avoids putting some [...] files to /tmp/cc* when
>>> -save-temps has been specified.
>>>
>>> For my testcase, it now generates:
>>> a.lto_wrapper_args
>>> a.offload_args
>>> a.xnvptx-none.args
>>> a.xnvptx-none.gcc_args
>>> a.xamdgcn-amdhsa.gcc_args
>>> a.xamdgcn-amdhsa.gccnative_args
>>> a.xamdgcn-amdhsa.ld_args
>>>
>>>
>>> This patch adds an additional argument to collect-utils.c's
>>> collect_execute (and is wrapper fork_execute) which, if not NULL,
>>> it is used in 'concat (dumppfx, atsuffix, NULL);'.
>>>
>>> This patch adds a suffix to gcc/config/gcn/mkoffload.c,
>>> gcc/config/nvptx/mkoffload.c and gcc/lto-wrapper.c.
>>>
>>> It does not (yet) add a suffix to gcc/collect2.c and
>>> gcc/config/i386/intelmic-mkoffload.c but just passes
>>> NULL; for intelmic it is not a work item as it does
>>> not use '@' files at all.
>>>
>>> Hopefully, there is no file which is written twice
>>> with the same name (or otherwise overridden) and
>>> the files names do make sense.
>>>
>>> OK?
>>>
>>> Tobias
>>>
>>> PS: There is still cceBdzZk.ofldlist (via lto-plugin/lto-plugin.c),
>>> and @/tmp/cc* in calls to lto1 and collect2. And collect2.c
>>> passes NULL also when use_atfile is true.
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: committed.diff
Type: text/x-patch
Size: 13094 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20201020/bec440eb/attachment-0001.bin>