[PATCH] vrp: Fix up gcc.target/aarch64/pr90838.c [PR97312, PR94801]

[Aldy Hernandez]

On 10/8/20 5:08 PM, Jakub Jelinek wrote:
> On Thu, Oct 08, 2020 at 04:55:07PM +0200, Aldy Hernandez via Gcc-patches wrote:
>>> Yes, for max == 0 aka [0, 0] I wanted:
>>> 1) if mini == -1, i.e. the DEFINED_VALUE_AT_ZERO == 2 VALUE is -1, return [-1, -1]
>>> 2) if maxi == prec, i.e. DEFINED_VALUE_AT_ZERO == 2 VALUE is prec, return [prec, prec]
>>
>> Ah, I see.  Do you mind commenting that?  Or perhaps you could spell it out
>> obviously like:
>>
>> if (max == 0) {
>> 	...
>> 	if (DEFINED_VALUE_AT_ZERO)
>> 		// do special things
>> 	...
>> }
>>
>> But whatever is fine.  I hope to never look at these bits ever again :).
> 
> Added several comments now (but just in gimple-range.cc, I assume
> vr-values.c code is what you want to kill eventually).

Thanks, and yes... vr-values is on life support :).

Aldy