[PATCH] gcc-changelog: Add libstdc++-v3/testsuite to wildcard prefixes

Jonathan Wakely jwakely@redhat.com
Fri Nov 27 16:23:54 GMT 2020


This allows using "testsuite/*" in libstdc++-v3/ChangeLog entries, which
was one of the original motivations for adding wildcard support in the
first place:
https://gcc.gnu.org/pipermail/gcc/2020-June/232719.html

contrib/ChangeLog:

	* gcc-changelog/git_commit.py (wildcard_prefixes): Add libstdc++
	testsuite directory.

OK to push?

This still doesn't actually meet my needs, because I'd like to be able
to do:

	* testsuite/foo/*: Something for foo tests.
	* testsuite/bar/baz/*: Something for baz tests.

So it would be nice if wildcards worked for any directory below a
wildcard prefix (as long as the directory actually exists).

It also seems that I can't have a commit where all changes are
described by a wildcard entry. It seems to require a non-wildcard one
too. But that means I can't make changes to hundreds of tests without
also making some other change, or doing something like:

	* testsuite/foo/foo-1.cc: A specific change.
        * testsuite/*: Likewise.

I suppose I can live with the latter, but it would still be nice if
this worked:

	* testsuite/foo/foo-1.cc: A specific change.
        * testsuite/foo/*: Likewise.
        * testsuite/bar/baz/*: Likewise.

i.e. sub-directories below a wildcard prefix.


-------------- next part --------------
commit 5cdb6541a49f1ac716a3f1be281c9487d9b198c5
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Nov 27 16:00:58 2020

    gcc-changelog: Add libstdc++-v3/testsuite to wildcard prefixes
    
    This allows using "testsuite/*" in libstdc++-v3/ChangeLog entries, which
    was one of the original motivations for adding wildcard support in the
    first place:
    https://gcc.gnu.org/pipermail/gcc/2020-June/232719.html
    
    contrib/ChangeLog:
    
            * gcc-changelog/git_commit.py (wildcard_prefixes): Add libstdc++
            testsuite directory.

diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py
index d0ac23c22aa4..3ebc6fd305e0 100755
--- a/contrib/gcc-changelog/git_commit.py
+++ b/contrib/gcc-changelog/git_commit.py
@@ -138,7 +138,8 @@ ignored_prefixes = {
 
 wildcard_prefixes = {
     'gcc/testsuite/',
-    'libstdc++-v3/doc/html/'
+    'libstdc++-v3/doc/html/',
+    'libstdc++-v3/testsuite/'
     }
 
 misc_files = {


More information about the Gcc-patches mailing list